Patch 1 #248
Open
Patch 1 #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sociated bgproutinginstance
mzbroch
requested changes
May 27, 2025
| <tr> | ||
| <td>Routing Instance</td> | ||
| <td><a href="{% url 'plugins:nautobot_bgp_models:bgproutinginstance' pk=object.peer_endpoint.routing_instance.pk %}">{{ object.peer_endpoint.routing_instance }}</a></td> | ||
| {% if object.peer_endpoint.routing_instance and object.peer_endpoint.routing_instance != '' %} |
Contributor
There was a problem hiding this comment.
Just the first check should be sufficient here.
Author
There was a problem hiding this comment.
It was not in my testing, since the model is defined and set as "" apparently?
Contributor
There was a problem hiding this comment.
It was not in my testing, since the model is defined and set as "" apparently?
That points to instance of BGPRoutingInstance, so should be either instance of BGPRoutingInstance or None on PeerEndpoint model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: No issue found regarding this fix
What's Changed
Added an if statement in the peerendpointaddressfamily_retrieve.html jinja view template to check if routing instance is defined and not "", preventing url not found errors from occurring on page load.
ONLY /nautobot_bgp_models/templates/nautobot_bgp_models/peerendpointaddressfamily_retrieve.html was modified. No python code or major changes made. very quick fix. Might not be your desired solution but it worked in my environment.
To Do
The above link is incorrect in your template ^
I imagine you intended to link to https://docs.nautobot.com/projects/core/en/stable/development/core/#creating-changelog-fragments